[Webkit-unassigned] [Bug 157066] REGRESSION(r200094): [FreeType] Vertical text is broken after r200094

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157066

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277466|0                           |1
        is obsolete|                            |
 Attachment #277466|review?                     |
              Flags|                            |
 Attachment #277467|                            |review?
              Flags|                            |

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 277467
  --> https://bugs.webkit.org/attachment.cgi?id=277467&action=review
Updated patch

I noticed that some tests (the ones using fallbacks) were crashing with this patch. The thing is that I wrongly assumed that the default copy constructor used the assign operator, but since that's not the case we need to keep our own implementation of the copy constructor. The good thing is that now we can use a unique_ptr (FcUniquePtr) for the fallbacks, which simplifies the code a bit more.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160427/562a662f/attachment.html>