[Webkit-unassigned] [Bug 150010] Web Inspector: React.js JSXTransformer produces bogus error locations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150010

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277288|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #9 from Brian Burg <bburg at apple.com> ---
Comment on attachment 277288
  --> https://bugs.webkit.org/attachment.cgi?id=277288
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=277288&action=review

Per IRC discussion let's rename at least the user-visible strings to "Extra Scripts". This will eventually be per-Frame and include InjectedScripts and any other 'eval'uations with a sourceURL.

> LayoutTests/inspector/model/frame-dynamic-scripts.html:36
> +                let mainFrame = WebInspector.frameResourceManager.mainFrame;

With just one frame in play here, this test isn't too good for detecting per-frame behavior. Is this handled by script-resource-relationship.html test? I had expected to see a new test case there.

> LayoutTests/inspector/model/frame-dynamic-scripts.html:38
> +                resolve();

If possible it would be nice to test that the dynamic scripts are cleared when the frame navigates. This might have to happen in an iframe to work around flaky test infrastructure caused by reloading the test page itself.

> Source/WebInspectorUI/UserInterface/Models/Script.js:48
> +        // with the frame as a dynamic script.

Is this so that hyperlinks to the fragment don't try to look it up in the document at 0/0?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160425/a2173d10/attachment.html>