[Webkit-unassigned] [Bug 150009] Web Inspector: Line error widget showed in the wrong resource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150009

--- Comment #13 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 277277
  --> https://bugs.webkit.org/attachment.cgi?id=277277
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=277277&action=review

> Source/WebInspectorUI/UserInterface/Controllers/IssueManager.js:45
> +        if (sourceCode instanceof WebInspector.Script)
> +            return issue.url === sourceCode.url || (issue.sourceCodeLocation && issue.sourceCodeLocation.sourceCode === sourceCode);

I think I should drop the url comparison here, or fallback to it if the sourceCodeLocation is unavailable. Otherwise, two dynamically added <script>s will both show this issue, even if the sourceCode specifically matches one of them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160425/533c8be7/attachment.html>