[Webkit-unassigned] [Bug 156994] http/tests/local/fileapi/file-last-modified-after-delete.html is flaky on mac-wk1 after r200032

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 25 16:00:20 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=156994

--- Comment #4 from Brady Eidson <beidson at apple.com> ---
(In reply to comment #3)
> I think I see what's going on here.
> 
> The File.lastModified accessor is returning a fractional number of
> milliseconds since the epoch.
> e.g., 1461624859783.417
> 
> Then the test end date is rounded to an integer number of milliseconds since
> epoch.
> e.g., 1461624859788
> 
> Those could very easily conflict the wrong way.
> e.g. 1461624859783.241 and 1461624859783.0 (1461624859783.49 rounded down)
> 
> Gotta do the rounding on the File's return value.
> 
> What's entirely unclear to me is how my change actually affected this. This
> should've been an existing problem.

Never mind - it is entirely clear!

lastModifiedDate used to be a Date object, which takes care of this.
lastModified is a double, which does not.

Fixing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160425/fcaefc41/attachment.html>


More information about the webkit-unassigned mailing list