[Webkit-unassigned] [Bug 156846] RenderStyle should not be reference counted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 24 20:37:49 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=156846

--- Comment #16 from Antti Koivisto <koivisto at iki.fi> ---
(In reply to comment #15)
> Comment on attachment 277143 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277143&action=review
> 
> This makes me wonder why these are heap allocated. Maybe at some point
> should passing RenderStyle&& and moving them instead of using objects on the
> heap and moving unique_ptrs around. I guess they are kind of big, though.

The plan is to move to RenderStyle&& in at least some places. One obvious thing we can do now is to inline RenderStyle to RenderElement, eliminating an allocation and indirection per renderer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160425/7440fd5a/attachment-0001.html>


More information about the webkit-unassigned mailing list