[Webkit-unassigned] [Bug 156850] Fixed compilation with !ENABLE(SVG_FONTS).

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 09:59:27 PDT 2016


--- Comment #5 from Konstantin Tokarev <annulen at yandex.ru> ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > We prefer guarding source files to guarding build sytem when it is possible.
> > 
> > It's the opposite of what we've been doing recently. Maybe we should discuss
> > this on webkit-dev?
> What do you mean? I haven't seen any patch removing if guards from source
> file.


Though in case of TEXTURE_MAPPER there is no direct condition in build system, instead choice is made by inclusion (or not inclusion) of TextureMapper.cmake in PlatformXXX.cmake.

> Source files are almost always guarded properly, I can't see a good reason
> to break this good practice now. I think most of the build system guard
> is redundant.

What is good about guards in .cpp files? They add no information in most cases, and also slightly increase build time, not only because of having to compile empty files, but also extra time is needed to generate large ninja manifest, also ninja has to process more edges.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160421/5ef8db31/attachment.html>

More information about the webkit-unassigned mailing list