[Webkit-unassigned] [Bug 156713] [Win][IndexedDB] Fix build errors.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156713

--- Comment #16 from peavo at outlook.com ---
(In reply to comment #14)
> Comment on attachment 276760 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276760&action=review
> 

Thanks for reviewing!

> 
> > Source/WebCore/bindings/js/JSDOMWindowBase.h:23
> > +#include "DOMWindow.h"
> 
> Is this really necessary?  What error does this prevent?  Can we not forward
> declare things?  Including more headers in a header like this makes the
> build slower.
> 

I get the error:

wtf/PassRefPtr.h(42): error C2027: use of undefined type 'WebCore::DOMWindow'

PassRefPtr<DOMWindow> is used in JSDOMWindowBase.h, but this fails to compile since the class DOMWindow is only forward declared here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160421/1bd3502a/attachment-0001.html>