[Webkit-unassigned] [Bug 156850] Fixed compilation with !ENABLE(SVG_FONTS).

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156850

--- Comment #2 from Csaba Osztrogonác <ossy at webkit.org> ---
Comment on attachment 276921
  --> https://bugs.webkit.org/attachment.cgi?id=276921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276921&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::FontCascade::drawGlyphBuffer): Deleted.

Please remove "Deleted." It must be a prepare-changelog bug.

> Source/WebCore/CMakeLists.txt:2864
> +if (ENABLE_SVG_FONTS)
> +    list(APPEND WebCore_SOURCES
> +        svg/SVGToOTFFontConversion.cpp
> +    )
> +endif ()

We prefer guarding source files to guarding build sytem when it is possible.

Myles, is it OK to add ENABLE(SVG_FONTS) guard to SVGToOTFFontConversion.cpp?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160421/518c0de4/attachment.html>