[Webkit-unassigned] [Bug 156849] New: Parsing of <body link vlink alink> is not per spec

Thu Apr 21 06:46:18 PDT 2016

https://bugs.webkit.org/show_bug.cgi?id=156849

            Bug ID: 156849
           Summary: Parsing of <body link vlink alink> is not per spec
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: zcorpan at gmail.com

(Same issue for Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=605534 )

https://github.com/WebKit/webkit/blob/66e68cd8d7bf4ea1cf52f31ed9cb242f83ea5b57/Source/WebCore/html/HTMLBodyElement.cpp#L159

This code does not match the requirements in the HTML spec:

[[
When a body element has a bgcolor attribute set, the new value is expected to be parsed using the rules for parsing a legacy colour value, and if that does not return an error, the user agent is expected to treat the attribute as a presentational hint setting the element's 'background-color' property to the resulting colour.

When a body element has a text attribute, its value is expected to be parsed using the rules for parsing a legacy colour value, and if that does not return an error, the user agent is expected to treat the attribute as a presentational hint setting the element's 'color' property to the resulting colour.

When a body element has a link attribute, its value is expected to be parsed using the rules for parsing a legacy colour value, and if that does not return an error, the user agent is expected to treat the attribute as a presentational hint setting the 'color' property of any element in the Document matching the :link pseudo-class to the resulting colour.

When a body element has a vlink attribute, its value is expected to be parsed using the rules for parsing a legacy colour value, and if that does not return an error, the user agent is expected to treat the attribute as a presentational hint setting the 'color' property of any element in the Document matching the :visited pseudo-class to the resulting colour.

When a body element has an alink attribute, its value is expected to be parsed using the rules for parsing a legacy colour value, and if that does not return an error, the user agent is expected to treat the attribute as a presentational hint setting the 'color' property of any element in the Document matching the :active pseudo-class and either the :link pseudo-class or the :visited pseudo-class to the resulting colour.
]]

https://html.spec.whatwg.org/multipage/rendering.html#the-page

It seems we use the correct rules for bgcolor (on various elements, and <font color>, <table bordercolor>, <hr color>) and text but not the link/vlink/alink attributes on body. This should also not be conditional on quirks mode. Gecko matches the spec AFAICT.

Simple tests:

<!doctype html>
<body bgcolor="00ff0x">This should have a green background.

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4091 bgcolor

---

<!doctype html>
<body link="00800x"><a href=javascript:>This text should be green.

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4092 link (standards mode)

---

<!doctype html>
<body link="00800x"><a href=javascript:>This text should be green.

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4093 link (quirks mode)

---

<body link="008000"><a href=javascript:>This text should be green.

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4094 link (quirks mode, using a value we successfully parse today)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160421/15ae6781/attachment.html>