[Webkit-unassigned] [Bug 156835] [GTK] WebKitWebView should claim the contents size as its natural size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 21 03:45:59 PDT 2016


--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 276902 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276902&action=review
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1536
> > +    if (priv->contentsSize == contentsSize)
> > +        return;
> > +    priv->contentsSize = contentsSize;
> The early check-and-return doesn't help much IMO, since the assignment is
> the only change of state here, and there's no work or event propagated
> further if the same size is assigned.

Yes, that's the case of this patch, but this is a actually a split of two patches. The other one adds new API to tell the web view to fit its size to the contents, so here I schedule a resize, but only when the contents size have actually changed.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160421/4fecb3a5/attachment.html>

More information about the webkit-unassigned mailing list