[Webkit-unassigned] [Bug 156835] [GTK] WebKitWebView should claim the contents size as its natural size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156835

Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276902|review?                     |review+
              Flags|                            |

--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 276902
  --> https://bugs.webkit.org/attachment.cgi?id=276902
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276902&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1536
> +    if (priv->contentsSize == contentsSize)
> +        return;
> +    priv->contentsSize = contentsSize;

The early check-and-return doesn't help much IMO, since the assignment is the only change of state here, and there's no work or event propagated further if the same size is assigned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160421/e456abaf/attachment.html>