[Webkit-unassigned] [Bug 156022] Web Inspector: sourceMappingURL not loaded in generated script

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 20 16:29:09 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=156022

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ggaren at apple.com,
                   |                            |mark.lam at apple.com,
                   |                            |sbarati at apple.com

--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Hmm, the so issue here is the sourceURL/sourceMappingURL do not get added when we skip re-parsing via the CodeCache:

When constructing the executable for `Function(str)` we go through:

    frame #0: JSC::CodeCache::getFunctionExecutableFromGlobalCode
    frame #1: JSC::UnlinkedFunctionExecutable::fromGlobalCode
    frame #2: JSC::FunctionExecutable::fromGlobalCode
    frame #3: JSC::constructFunctionSkippingEvalEnabledCheck
    frame #4: JSC::constructFunction
    frame #5: JSC::constructFunction
    frame #6: JSC::callFunctionConstructor

At which point if we do not have it in the CodeCache we parse it. If we do have this in the code cache, we return the cached unlinked function executable skipping parsing.

By skipping parsing we don't update the SourceProvider with the sourceURL/sourceMappingURL, because we normally do that under JSC::Parser<>::parse.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160420/837bdd6e/attachment.html>


More information about the webkit-unassigned mailing list