[Webkit-unassigned] [Bug 156713] [Win][IndexedDB] Fix build errors.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156713

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276760|review?                     |review-
              Flags|                            |

--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 276760
  --> https://bugs.webkit.org/attachment.cgi?id=276760
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276760&action=review

Looks good.  I think this needs another iteration, though.

> Source/WebCore/PlatformWin.cmake:189
>      Modules/indexeddb
> +    Modules/indexeddb/client

Style bot wants a space here.

> Source/WebCore/bindings/js/JSDOMWindowBase.h:23
> +#include "DOMWindow.h"

Is this really necessary?  What error does this prevent?  Can we not forward declare things?  Including more headers in a header like this makes the build slower.

> Source/WebCore/bindings/js/JSDOMWrapper.h:25
> +#include "DOMWrapperWorld.h"

Ditto.

> Source/WebKit/win/storage/WebDatabaseProvider.cpp:41
> +        return String("");

This isn't used in WebKit.  I think this is what emptyString() is for.

> Source/WebKit/win/storage/WebDatabaseProvider.cpp:50
> +        return String("");

ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160420/a919451e/attachment.html>