[Webkit-unassigned] [Bug 156147] [JSC] implement async functions proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156147

--- Comment #58 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 276565
  --> https://bugs.webkit.org/attachment.cgi?id=276565
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276565&action=review

A couple fly by comments. Will look more later.

> Source/JavaScriptCore/builtins/AsyncFunctionPrototype.js:33
> +    const Completed = -1;
> +    const Executing = -2;
> +
> +    const NormalMode = 0;
> +    const ThrowMode = 2;

Yusuke recently made these intrinsic values in byte code generator for generatorResume. I think we should do the same here for consistency.

> Source/JavaScriptCore/runtime/JSAsyncFunction.h:1
> +/*

Do we really need a separate class for this? It appears that this adds no new fields.
I haven't looked in great detail of where this is used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160419/cb599267/attachment.html>