[Webkit-unassigned] [Bug 156713] [Win][IndexedDB] Fix build errors.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 18 15:08:14 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=156713

--- Comment #6 from peavo at outlook.com ---
(In reply to comment #4)
> Comment on attachment 276667 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276667&action=review
> 
> cool!
> 

Thanks for reviewing :)

> > Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:44
> > -    return std::make_unique<MemoryBackingStoreTransaction>(backingStore, info);
> > +    return std::unique_ptr<MemoryBackingStoreTransaction>(new MemoryBackingStoreTransaction(backingStore, info));
> 
> This shouldn't be needed.
> 

I get a compile error without this:

error C2248: 'WebCore::IDBServer::MemoryBackingStoreTransaction::MemoryBackingStoreTransaction': cannot access private member declared in class 'WebCore::IDBServer::MemoryBackingStoreTransaction

Maybe we should fix this in another way?

> 
> > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1188
> > -    auto callback = [this, self, refTransaction](const IDBError& error) {
> > +    ErrorCallback callback = [this, self, refTransaction](const IDBError& error) {
> 
> This shouldn't be needed.
> 

I get an error without this:

error C2668: 'WebCore::IDBServer::UniqueIDBDatabase::storeCallback': ambiguous call to overloaded function

> > Source/WebKit/win/storage/WebDatabaseProvider.cpp:45
> > +    sprintf_s(databaseDirectory, MAX_PATH, "%s\\%s", appDataDirectory, executableName);
> 
> On Mac we use .../WebKit/Databases/___IndexedDB.  We should probably do
> something similar here.

I will update the path :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160418/42b1f895/attachment.html>


More information about the webkit-unassigned mailing list