[Webkit-unassigned] [Bug 151113] calling super() a second time in a constructor should throw

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151113

--- Comment #35 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 276261
  --> https://bugs.webkit.org/attachment.cgi?id=276261
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276261&action=review

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:4414
>> +        m_jit.compare64(JITCompiler::Equal, value.gpr(), TrustedImm32(ValueEmpty), result.gpr());
> 
> Yup, this is what I meant.
> 
> I think this is better written as:
> m_jit.comparePtr/compare64(JITCompiler::Equal, value.gpr(), TrustedImmPtr/TrustedImm32(JSValue()), result.gpr())

done

>> Source/JavaScriptCore/jit/JITOpcodes.cpp:185
>> +    compare64(Equal, regT0, TrustedImm32(ValueEmpty), regT0);
> 
> ditto here.

done

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160415/8561c2b6/attachment.html>