[Webkit-unassigned] [Bug 155367] Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 13:39:21 PDT 2016


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
           Assignee|webkit-unassigned at lists.web |ap at webkit.org
                   |kit.org                     |
           See Also|                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=54790,
                   |                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=98196

--- Comment #1 from Alexey Proskuryakov <ap at webkit.org> ---
I think that this was introduced by this change, unclear if it was even intentional: <http://trac.webkit.org/changeset/89400/trunk/Tools/Scripts/webkitpy/common/system/executive.py>

Doing a non-blocking waitpid followed by another waitpid is super racy, and no wonder that the second one sometimes fails.

Can't say that I like overall design of this code either - it relies on an exception as part of normal operation.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160412/4beaf070/attachment-0001.html>

More information about the webkit-unassigned mailing list