No subject


Mon Apr 4 20:22:20 PDT 2016


-- 
You are receiving this mail because:
You are the assignee for the bug.
--1459989823.Ac7C27.12888
Date: Wed, 6 Apr 2016 17:43:43 -0700
MIME-Version: 1.0
Content-Type: text/html

<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:dbates&#64;webkit.org" title="Daniel Bates &lt;dbates&#64;webkit.org&gt;"> <span class="fn">Daniel Bates</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Adding layout tests for the bot watcher's dashboard QUnit tests."
   href="https://bugs.webkit.org/show_bug.cgi?id=155272">bug 155272</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #275572 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Adding layout tests for the bot watcher's dashboard QUnit tests."
   href="https://bugs.webkit.org/show_bug.cgi?id=155272#c19">Comment # 19</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Adding layout tests for the bot watcher's dashboard QUnit tests."
   href="https://bugs.webkit.org/show_bug.cgi?id=155272">bug 155272</a>
              from <span class="vcard"><a class="email" href="mailto:dbates&#64;webkit.org" title="Daniel Bates &lt;dbates&#64;webkit.org&gt;"> <span class="fn">Daniel Bates</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=275572&amp;action=diff" name="attach_275572" title="Patch">attachment 275572</a> <a href="attachment.cgi?id=275572&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275572&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=275572&amp;action=review</a>

<span class="quote">&gt; Tools/ChangeLog:31
&gt; +        Updated the unit tests for Trac._loaded to point to the XML files that are now located in the 'resources' directory.</span >

Nit: Trac._loaded =&gt; Trac._loaded()

(since this is a function)

<span class="quote">&gt; Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:51
&gt; +    client.open('GET', './resources/test-fixture-trac-rss.xml', false);</span >

Please remove the leading &quot;./&quot;. from the file path. Additionally, we should take this opportunity to fix the quoting style on this line to use double quoted string literals since we need to modify it anyway. Making this change will make the quoting style uses in this line consistent with the quoting style used throughout this file.

<span class="quote">&gt; Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:68
&gt; +    client.open(&quot;GET&quot;, &quot;./resources/test-fixture-git-trac-rss.xml&quot;, false);</span >

Please remove the leading &quot;./&quot; from the file path.

<span class="quote">&gt; Tools/Scripts/run-dashboard-tests:1
&gt; +#! /bin/sh</span >

Please remove the space character between the &quot;!&quot; and &quot;/&quot;.

<span class="quote">&gt; Tools/Scripts/run-dashboard-tests:26
&gt; +RUN_WEBKIT_TESTS=&quot;$(dirname $0)/run-webkit-tests&quot;</span >

We should extract $(dirname $0) into a variable, say TOOLS_DIRECTORY, and then reference this variable in the definition of RUN_WEBKIT_TESTS and TEST_DIRECTORY instead of duplicating code.

<span class="quote">&gt; Tools/Scripts/run-dashboard-tests:29
&gt; +$RUN_WEBKIT_TESTS --layout-tests-directory=$TEST_DIRECTORY $*</span >

Run `run-dashboard-tests --results-directory &quot;my results&quot;`

Then this script will invoke:

run-webkit-tests --layout-tests-directory=$TEST_DIRECTORY --results-directory my results

Notice that the single argument &quot;my results&quot; will be split into two arguments that are passed to run-webkit-tests.



More information about the webkit-unassigned mailing list