[Webkit-unassigned] [Bug 155272] Adding layout tests for the bot watcher's dashboard QUnit tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155272

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275572|review?                     |review+
              Flags|                            |

--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 275572
  --> https://bugs.webkit.org/attachment.cgi?id=275572
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275572&action=review

> Tools/ChangeLog:31
> +        Updated the unit tests for Trac._loaded to point to the XML files that are now located in the 'resources' directory.

Nit: Trac._loaded => Trac._loaded()

(since this is a function)

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:51
> +    client.open('GET', './resources/test-fixture-trac-rss.xml', false);

Please remove the leading "./". from the file path. Additionally, we should take this opportunity to fix the quoting style on this line to use double quoted string literals since we need to modify it anyway. Making this change will make the quoting style uses in this line consistent with the quoting style used throughout this file.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:68
> +    client.open("GET", "./resources/test-fixture-git-trac-rss.xml", false);

Please remove the leading "./" from the file path.

> Tools/Scripts/run-dashboard-tests:1
> +#! /bin/sh

Please remove the space character between the "!" and "/".

> Tools/Scripts/run-dashboard-tests:26
> +RUN_WEBKIT_TESTS="$(dirname $0)/run-webkit-tests"

We should extract $(dirname $0) into a variable, say TOOLS_DIRECTORY, and then reference this variable in the definition of RUN_WEBKIT_TESTS and TEST_DIRECTORY instead of duplicating code.

> Tools/Scripts/run-dashboard-tests:29
> +$RUN_WEBKIT_TESTS --layout-tests-directory=$TEST_DIRECTORY $*

Run `run-dashboard-tests --results-directory "my results"`

Then this script will invoke:

run-webkit-tests --layout-tests-directory=$TEST_DIRECTORY --results-directory my results

Notice that the single argument "my results" will be split into two arguments that are passed to run-webkit-tests.