[Webkit-unassigned] [Bug 116046] FKA: activating a fragment ID URL (in-page link or external link with hash) should transfer focus and caret to the fragment target element with ID or name matching the fragment identifier

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 00:26:43 PDT 2016


--- Comment #15 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 275757
  --> https://bugs.webkit.org/attachment.cgi?id=275757
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275757&action=review

> Source/WebCore/dom/Document.cpp:3933
> +    return node && (is<HTMLIFrameElement>(*node) || is<HTMLHtmlElement>(*node) || is<HTMLDocument>(*node));

you could make this Node& node and dispense with the node check

> Source/WebCore/dom/Document.cpp:3964
> +        Node* node = &m_focusNavigationStartingPoint->startContainer();

you can probably leave this in & form

> LayoutTests/fast/events/sequential-focus-navigation-starting-point-expected.txt:6
> +PASS After removing a focused element from the documen tree, sequential focus navigation should start at a place where the focused element was. 

documen -> document

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160406/436798dc/attachment.html>

More information about the webkit-unassigned mailing list