[Webkit-unassigned] [Bug 156235] Shadow DOM: :host() From The First Shadow Context Should Not Style All Shadow Context

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156235

Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275669|review?                     |review+
              Flags|                            |

--- Comment #4 from Andreas Kling <akling at apple.com> ---
Comment on attachment 275669
  --> https://bugs.webkit.org/attachment.cgi?id=275669
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275669&action=review

r=me

> Source/WebCore/style/StyleSharingResolver.cpp:100
> +    if (element.shadowRoot() && !element.shadowRoot()->styleResolver().ruleSets().authorStyle()->hostPseudoClassRules().isEmpty())

This would look so nice if we made authorStyle() return a reference, too.

> Source/WebCore/style/StyleSharingResolver.cpp:287
> +    if (element.shadowRoot() && !element.shadowRoot()->styleResolver().ruleSets().authorStyle()->hostPseudoClassRules().isEmpty())

Mhm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160405/ceb9a3b2/attachment.html>