[Webkit-unassigned] [Bug 156118] [iOS] Allow clients to know whether a field was focused by user interaction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156118

mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275435|review?                     |review-
              Flags|                            |

--- Comment #2 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 275435
  --> https://bugs.webkit.org/attachment.cgi?id=275435
Patch for [iOS] Allow clients to know whether a field was focused by user interaction

View in context: https://bugs.webkit.org/attachment.cgi?id=275435&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3529
>      RetainPtr<WKFocusedElementInfo> focusedElementInfo = adoptNS([[WKFocusedElementInfo alloc] initWithAssistedNodeInformation:information isUserInitiated:userIsInteracting]);
>      BOOL shouldShowKeyboard;

This indicates that focusedElementInfo’s userInitiated property is initialized to the value of userIsInteracting. Given that, and given that the existing delegate method already receives focusedElementInfo as an argument, I think you shouldn’t introduce a new delegate method with a separate redundant argument.

But I am also not seeing how this method is the right place to make the change that balances out the change in WebPageIOS.mm below. Shouldn’t you be changing the implementation of willBeginInputSession in WKWebProcessPlugInBrowserContextController?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160401/39455c99/attachment.html>