[Webkit-unassigned] [Bug 155545] [ES6] Class syntax. Access to new.target inside of the eval should not lead to SyntaxError

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155545

--- Comment #9 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 275212
  --> https://bugs.webkit.org/attachment.cgi?id=275212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275212&action=review

>> Source/JavaScriptCore/runtime/CodeCache.cpp:86
>> +UnlinkedCodeBlockType* CodeCache::getGlobalCodeBlock(VM& vm, ExecutableType* executable, const SourceCode& source, JSParserBuiltinMode builtinMode, JSParserStrictMode strictMode, ThisTDZMode thisTDZMode, bool, DebuggerMode debuggerMode, ProfilerMode profilerMode, ParserError& error, bool isParantProgramParseMode, const VariableEnvironment* variablesUnderTDZ)
> 
> Is this truly just the parent? Or is this parent or self is program?
> i.e, should a Program node be true or false for this?

In general for Program node it should be does not matter. I've made refactoring in  next patch, so it reflect that this value is matter only in eval context.

>> Source/JavaScriptCore/runtime/CodeCache.cpp:147
>> +    return getGlobalCodeBlock<UnlinkedModuleProgramCodeBlock>(vm, executable, source, builtinMode, JSParserStrictMode::Strict, ThisTDZMode::CheckIfNeeded, false, debuggerMode, profilerMode, error, false, &emptyParentTDZVariables);
> 
> It doesn't make sense that this is different from UnlinkedProgramCodeBlock

Fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160401/6f0d68ba/attachment.html>