[Webkit-unassigned] [Bug 149676] Implement keyboard event sending for iOS in WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149676

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262232|review?                     |review+
              Flags|                            |

--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 262232
  --> https://bugs.webkit.org/attachment.cgi?id=262232
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262232&action=review

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:66
> +        NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
> +        [center addObserver:self selector:@selector(_keyboardDidShow:) name:UIKeyboardDidShowNotification object:nil];
> +        [center addObserver:self selector:@selector(_keyboardDidHide:) name:UIKeyboardDidHideNotification object:nil];

You need to call removeObserver in -dealloc.

> Tools/WebKitTestRunner/ios/IOKitSPI.h:131
> +    kHIDPage_KeyboardOrKeypad = 0x07

Move this up above kHIDPage_VendorDefinedStart.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151001/361dd272/attachment-0001.html>