[Webkit-unassigned] [Bug 149676] Implement keyboard event sending for iOS in WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149676

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 262196
  --> https://bugs.webkit.org/attachment.cgi?id=262196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262196&action=review

> Tools/WebKitTestRunner/ios/HIDEventGenerator.h:54
> +- (void)keyDown:(NSString*)character completionBlock:(void (^)(void))completionBlock;

space before the star.

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:443
> +    if ([key length] != 1)

dot?

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:481
> +    if ([key length] == 1) {

dot.

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:495
> +        case '`':

Is there really nothing in the system that can do this for us (even if it's SPI?).

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:98
> +    TestRunnerWKWebView* webView = TestController::singleton().mainWebView()->platformView();

star's on the wrong side

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:100
> +    NSString* characterAsNSString = [[NSString stringWithCString:toSTD(toWK(character)).c_str()] autorelease];

I'm sure there's a better way to get a NSString from a WKString. Going through std::string is crazy. At the very least, use WKStringGetUTF8CString instead of std::string::c_str(), no?

Also, star.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150930/3d3d7263/attachment-0001.html>