No subject

Mon Sep 28 12:00:37 PDT 2015

this._element.classList.add("find-banner");
if (className && className.length)
    this._element.classList.add(className):

This ensures that all FindBanners have the same default styling specified in FindBanner.css but also have the ability to have extra styling applied through this className arg (use this for my comment in ConsoleFindBanner.css).

-- 
You are receiving this mail because:
You are the assignee for the bug.
--1443547287.f75E5.6072
Date: Tue, 29 Sep 2015 10:21:27 -0700
MIME-Version: 1.0
Content-Type: text/html

<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner"
   href="https://bugs.webkit.org/show_bug.cgi?id=149505#c10">Comment # 10</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner"
   href="https://bugs.webkit.org/show_bug.cgi?id=149505">bug 149505</a>
              from <span class="vcard"><a class="email" href="mailto:dcrousso+webkit&#64;gmail.com" title="Devin Rousso &lt;dcrousso+webkit&#64;gmail.com&gt;"> <span class="fn">Devin Rousso</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=261961&amp;action=diff" name="attach_261961" title="patch">attachment 261961</a> <a href="attachment.cgi?id=261961&amp;action=edit" title="patch">[details]</a></span>
patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261961&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=261961&amp;action=review</a>

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Views/ConsoleFindBanner.css:58
&gt; +.console-find-banner &gt; input[type=&quot;search&quot;] {</span >

Is this CSS rule the only reason that you created ConsoleFindBanner.css?  If so, please delete this file and just add this rule to FindBanner.css like so:

.find-banner.console-find-banner &gt; input[type=&quot;search&quot;] {
    ...
}

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Views/FindBanner.js:28
&gt; +    constructor(delegate, className = &quot;find-banner&quot;, fixed = false)</span >

I would actually change how you are currently doing the className to always add &quot;find-banner&quot; and, if the user specifies a className in the constructor, add another classname:

constructor(delegate, className, fixed = false)

<span class="quote">&gt; Source/WebInspectorUI/UserInterface/Views/FindBanner.js:34
&gt; +        this._element.classList.add(className);</span >