[Webkit-unassigned] [Bug 149505] Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 29 10:21:43 PDT 2015


--- Comment #10 from Devin Rousso <dcrousso+webkit at gmail.com> ---
Comment on attachment 261961
  --> https://bugs.webkit.org/attachment.cgi?id=261961

View in context: https://bugs.webkit.org/attachment.cgi?id=261961&action=review

> Source/WebInspectorUI/UserInterface/Views/ConsoleFindBanner.css:58
> +.console-find-banner > input[type="search"] {

Is this CSS rule the only reason that you created ConsoleFindBanner.css?  If so, please delete this file and just add this rule to FindBanner.css like so:

.find-banner.console-find-banner > input[type="search"] {

> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:28
> +    constructor(delegate, className = "find-banner", fixed = false)

I would actually change how you are currently doing the className to always add "find-banner" and, if the user specifies a className in the constructor, add another classname:

constructor(delegate, className, fixed = false)

> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:34
> +        this._element.classList.add(className);

More information about the webkit-unassigned mailing list