[Webkit-unassigned] [Bug 149627] New: [GTK][CMake] Warning about CMP0058

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149627

            Bug ID: 149627
           Summary: [GTK][CMake] Warning about CMP0058
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

Since CMake 3.3:

CMake Warning (dev):
  Policy CMP0058 is not set: Ninja requires custom command byproducts to be
  explicit.  Run "cmake --help-policy CMP0058" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  This project specifies custom command DEPENDS on files in the build tree
  that are not specified as the OUTPUT or BYPRODUCTS of any
  add_custom_command or add_custom_target:

   DerivedSources/webkit2gtk/WebKit2ResourcesGResourceBundle.xml

  For compatibility with versions of CMake that did not have the BYPRODUCTS
  option, CMake is generating phony rules for such files to convince 'ninja'
  to build.

  Project authors should add the missing BYPRODUCTS or OUTPUT options to the
  custom commands that produce these files.
This warning is for project developers.  Use -Wno-dev to suppress it.


There is no way to get rid of the warning using the old policy, except to stop using the file command to generate WebKit2ResourcesGResourceBundle.xml and to use a custom script to do it instead, which would be a crazy unnecessary workaround. At http://public.kitware.com/pipermail/cmake/2015-September/061672.html one of the CMake developers notes that it's safe in our case to just switch to the new policy, so let's just do that. The risk is that someone using an old CMake might in the future break the build for people using modern CMake, but that would be noticed pretty quickly....

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150929/d7bced59/attachment.html>