[Webkit-unassigned] [Bug 149556] Improve binding of JSBuiltinConstructor classes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 28 17:14:42 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=149556

--- Comment #5 from Darin Adler <darin at apple.com> ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > This is not what we want, we want a new object each time.
> > 
> > Why?
> 
> All other wrapper classes have that behavior.
> I think (jsObject == toJS(toWrapped(jsObject))) is true for all classes for
> instance.
> Breaking that behavior might not break any existing code but this looks
> misleading to me.

Sure, slightly inelegant, but I’m almost certain it will work just fine.

> Removing generation of that code (toJS, toWrapped, Wrapper owner code) for
> JS builtin constructed classes makes sense to me, whether we keep a dummy
> DOM class or not.
> 
> With limited refactoring, this might be healthy for the binding generator
> code as well.

Sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150929/3c644e64/attachment.html>


More information about the webkit-unassigned mailing list