[Webkit-unassigned] [Bug 149586] New: GC copy phase spans too many files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149586

            Bug ID: 149586
           Summary: GC copy phase spans too many files
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

Current the GC copy phase has some code in HeapInlines.h that gets included into every file in WebKit, some code in Heap.cpp, some code in CopyVisitor.cpp, and some in CopyVisitorInlines.h.  Also, CopyVisitor has this peculiar idiom where you always use it by first instantiating it, then calling an init method, then doing things, then calling a tear-down method, and then calling some malloc method, and then destructing the CopyVisitor.  That's too complicated.

Part of the problem is that we have a fairly clever sharding work distribution algorithm that uses Heap as the place where we hold shared state.  We don't really have to do that.  Because we now use a lambda-based parallelism API (ParallelHelperPool), we could just have the state on the stack, and have all of the functionality in one place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150927/c081c994/attachment.html>