[Webkit-unassigned] [Bug 148376] New tests introduced in r188545 fail on 32 bit ARM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148376

--- Comment #17 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 261574
  --> https://bugs.webkit.org/attachment.cgi?id=261574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261574&action=review

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4660
>> +        DFG_TYPE_CHECK(thisValue.jsValueRegs(), node->child2(), SpecCell, m_jit.branchIfNotCell(thisValue.jsValueRegs()));
> 
> When would this ever not be a cell?

At start child2 type is SpeculatedType SpecHeapTop  = 0x3bbfffff -> after this line it converts to SpeculatedType SpecCell = 0x000fffff
Without this line this code raise ASSERT error in following module https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h#L120
and it says that it expect Cell but there was Top. 
In JSVALUE64 branch this type check is done by following statement SpeculateCellOperand thisValue(this, node->child2()); (4653)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150921/4e2f8b0a/attachment.html>