[Webkit-unassigned] [Bug 148376] New tests introduced in r188545 fail on 32 bit ARM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148376

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #261538|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #14 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 261538
  --> https://bugs.webkit.org/attachment.cgi?id=261538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261538&action=review

r=me with some nits.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4641
> +#if !USE(JSVALUE32_64)

nit: make this "USE(JSVALUE64)"

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4652
> +#if !USE(JSVALUE32_64)

nit: make this "USE(JSVALUE64)"

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4671
> +#if !USE(JSVALUE32_64)

ditto

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4705
> +#if !USE(JSVALUE32_64)

ditto

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4709
> +        m_jit.storePtr(thisValueTagGPR, MacroAssembler::Address(resultGPR, JSArrowFunction::offsetOfThisValue() + TagOffset));

nit: I would also make this store32.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150919/971d5695/attachment.html>