[Webkit-unassigned] [Bug 148945] Implement the arithmetic instructions for doubles in WebAssembly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148945

--- Comment #10 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
(In reply to comment #5)
> Comment on attachment 260994 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260994&action=review
> 
> > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:77
> > +// On Windows we need to wrap fmod; on other platforms we can call it directly.
> > +// On ARMv7 we assert that all function pointers have to low bit set (point to thumb code).
> > +#if CALLING_CONVENTION_IS_STDCALL || CPU(ARM_THUMB2)
> > +static double JIT_OPERATION operationFmod(double x, double y)
> 
> to low bit => the low bit
> 
> I don't understand this comment. Why do we need to wrap fmod on Windows?
> Your comment says that we need to wrap fmod on Windows and not other
> platforms, but your code tests for all stdcall and/or thumb2 platforms. Why
> is it relevant that ARMv7 code is thumb code?

I copied this code from dfg/DFGSpeculativeJIT.cpp. My guess is that fmod was written in non-thumb code. I have removed the wrapper for fmod and tested this patch on ARMv7 and ARM64 with the help of Michael. It passes every WASM test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150918/ca82f657/attachment.html>