[Webkit-unassigned] [Bug 148963] Implement EventSenderProxy for WebKitTestRunner on iOS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 11:44:24 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=148963

--- Comment #17 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to comment #16)
> Comment on attachment 261079 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261079&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.h:1082
> > +    void sendForceRepaintWithCallback(RefPtr<VoidCallback>);
> 
> Argument types should almost never be RefPtr. Please consider a plain
> reference or pointer or RefPtr&& or Ref&&. Details at
> <http://www.webkit.org/coding/RefPtr.html>.

Got it -- I'll change this. Thanks for the link!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150916/3142ceb9/attachment.html>


More information about the webkit-unassigned mailing list