[Webkit-unassigned] [Bug 149222] New: webkit-patch rollout should not die when passed a unicode character in the message

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149222

            Bug ID: 149222
           Summary: webkit-patch rollout should not die when passed a
                    unicode character in the message
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bburg at apple.com
                CC: achristensen at apple.com, ap at webkit.org,
                    dbates at webkit.org, ddkilzer at webkit.org,
                    jhoneycutt at apple.com, joepeck at webkit.org,
                    lforschler at apple.com, rniwa at webkit.org

This most often manifests as webkitbot refusing to do a rollout:

09:53 <alexchristensen> webkitbot: rollout 189851 189853 didn’t actually fix permissions issue
09:53 <webkitbot> alexchristensen: Preparing rollout for http://trac.webkit.org/changeset/189851 and http://trac.webkit.org/changeset/189853 ...
09:53 <webkitbot> Exception executing command: 'ascii' codec can't decode byte 0xe2 in position 4: ordinal not in range(128)

I added a parse test to irc_command_unittests.py to verify that the problem is not specific to the IRC bot's parser. It probably happens somewhere deeper in the rollout command.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150916/43fdff88/attachment.html>