[Webkit-unassigned] [Bug 149154] CurrentTime on mediaController is set as 0 when playback is completed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 10:01:06 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=149154

--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 261294
  --> https://bugs.webkit.org/attachment.cgi?id=261294
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261294&action=review

> Source/WebCore/html/MediaController.cpp:458
>      case ENDED:
>          eventName = eventNames().endedEvent;
> +        m_resetCurrentTimeInNextPlay = true;
>          m_clock->stop();
> -        m_clock->setCurrentTime(0);
>          m_timeupdateTimer.stop();
>          break;

Instead of adding a new instance variable to track state, can you just set current time to 0 when playback state changes from ENDED to PLAYING?

    case PLAYING:
        if (oldReadyState == ENDED)
            m_clock->setCurrentTime(0);
        eventName = eventNames().playingEvent;
        m_clock->start();
        startTimeupdateTimer();
        break;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150916/36ebefa9/attachment.html>


More information about the webkit-unassigned mailing list