[Webkit-unassigned] [Bug 149209] New: prepare-ChangeLog skips modified function if Git is configured with diff.mnemonicprefix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149209

            Bug ID: 149209
           Summary: prepare-ChangeLog skips modified function if Git is
                    configured with diff.mnemonicprefix
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ansh_shukla at apple.com

Users who have ``git config diff.mnemonicprefix=true`` will not have modified functions listed in their ChangeLog because diffHeaderFormat() is looking for headers of the form: ``return qr/^diff --git a\/.+ b\/(.+)$/ if isGit();``, but mnemonicprefix will change "a" and "b" to 'i', 'w', 'c', or 'o'.

I think it's better to fix by changing the config for the diff command via option ``-c diff.mnemonicprefix=false``, but am open to other suggestions (e.g. changing the RegEx).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150916/78fa0317/attachment.html>