[Webkit-unassigned] [Bug 148388] We should also store the time information for recent searches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148388

Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #261233|review?                     |review-
              Flags|                            |

--- Comment #15 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 261233
  --> https://bugs.webkit.org/attachment.cgi?id=261233
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=261233&action=review

I think you should use std::chrono::system_clock::time_point for times instead of double - then you can use std::chrono::system_clock::now() to create a time.

You can convert between time_points and NSDates using

    NSTimeInterval timeInterval = std::chrono::duration_cast<std::chrono::duration<double>>(modifiedSince.time_since_epoch()).count();
    NSDate *date = [NSDate dateWithTimeIntervalSince1970:timeInterval];

Does older versions of WebKit deal with the updated user defaults format?

> Source/WebCore/platform/win/SearchPopupMenuWin.cpp:96
> +        if (CFGetTypeID(item) == CFArrayGetTypeID() && CFArrayGetCount((CFArrayRef)item) == 2) {

Can use dynamic_cf_cast here.

> Source/WebKit/mac/WebCoreSupport/SearchPopupMenuMac.mm:64
> +        [items addObject:[NSArray arrayWithObjects:searchItem.first, [[NSNumber alloc] initWithDouble:searchItem.second], nil]];

I think you should use NSDate for the times instead.

> Source/WebKit/mac/WebCoreSupport/SearchPopupMenuMac.mm:77
> +        if ([item isKindOfClass:[NSArray class]] && ((NSArray*)item).count == 2)
> +            searchItems.append(std::make_pair((String)item[0], ((NSNumber*)item[1]).doubleValue));

You can use dynamic_objc_cast here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150915/28f18c5f/attachment.html>