[Webkit-unassigned] [Bug 149093] Implement calls to JavaScript functions in WebAssembly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149093

--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 261064
  --> https://bugs.webkit.org/attachment.cgi?id=261064
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261064&action=review

> Source/JavaScriptCore/wasm/WASMModuleParser.cpp:53
> +    : m_exec(exec)

We should avoid doing this.  ExecState* really means a frame pointer, so it's only valid during execution, and using it here can cause three other problems:
1) Impossible to make this code run concurrently.
2) Too easy to introduce user-observable effects.  We usually only pass around ExecState* when we're in a context where it's OK to have user-observed effects.
3) Too easy to make the parser impure - i.e. somehow dependent on the current state of the world.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150915/27fae31e/attachment.html>