[Webkit-unassigned] [Bug 149131] Polish code for r189579.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149131

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #261130|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 261130
  --> https://bugs.webkit.org/attachment.cgi?id=261130
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261130&action=review

r=me with comments.

> Source/WebCore/ChangeLog:9
> +        "characterSetForBindings". And optimize the way to get text encoding. This is a fix for bug 148810.

Don't start the sentence with "And".
Also try to wrap your ChangeLog at ~80 characters.

> Source/WebCore/dom/Document.h:1751
> +    if (TextResourceDecoder *d = decoder())

Star on wrong side, also, you can use auto*
Also, don't use 'd', no abbreviated names.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150914/8c6d7ab5/attachment.html>