[Webkit-unassigned] [Bug 149102] Implement the arithmetic instructions for floats in WebAssembly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149102

--- Comment #4 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
Thanks for the review.

(In reply to comment #3)
> Comment on attachment 261106 [details]
> Patch
> 
> These conversions are pretty expensive. Why not just do the math as float?

Our macro assembler currently doesn't have any float arithmetic instructions. I could add them for x86, x86-64, and ARM. But I am not sure how to add and test them on MIPS and SH4. Is it OK if I just add them for x86, x86-64, and ARM and do something like

#if CPU(X86) || CPU(X86_64)
    m_assembler.addsd_rr(...);
#elif CPU(ARM) || CPU(ARM64) 
    m_assembler....(...);
#else
    convertFloatToDouble(FPRInfo::fpRegT0, FPRInfo::fpRegT0);
    addDouble(FPRInfo::fpRegT1, FPRInfo::fpRegT0);
    convertDoubleToFloat(FPRInfo::fpRegT0, FPRInfo::fpRegT0);
#endif

?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150914/8672b577/attachment.html>