[Webkit-unassigned] [Bug 148678] Web Inspector: visual style editor fields should restore previous value when invalid inputs are entered

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 16:02:25 PDT 2015


--- Comment #2 from Devin Rousso <dcrousso+webkit at gmail.com> ---
(In reply to comment #0)
> We shouldn't be storing the input state in the DOM, it should be kept in the
> widget class separately and synced when valid values are committed.

I agree with you that we should have member variables for the current value, but I am not sure about "restore previous value when invalid inputs are entered".  What exactly do you mean by that?  Would it be something like "display: foo;"?  If so, I don't think we should just revert to the previous value because that would remove any support for other browsers/custom css.  Maybe something like a warning saying "this won't work"...

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150908/8a2e6309/attachment.html>

More information about the webkit-unassigned mailing list