[Webkit-unassigned] [Bug 145605] Function.prototype.bind: Bound functions must use the [[Prototype]] of their target function instead of Function.prototype
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 8 15:40:02 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=145605
Geoffrey Garen <ggaren at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #260799|review? |review-
Flags| |
--- Comment #9 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 260799
--> https://bugs.webkit.org/attachment.cgi?id=260799
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=260799&action=review
> Source/JavaScriptCore/runtime/JSBoundFunction.cpp:83
> JSBoundFunction* function = new (NotNull, allocateCell<JSBoundFunction>(vm.heap)) JSBoundFunction(vm, globalObject, globalObject->boundFunctionStructure(), targetFunction, boundThis, boundArgs);
You can see that this code believed it could share a structure between all bound functions in a global object. Your patch makes that fact no longer true. It would be preferable to remove the old code, which attempted to share a structure, and simply allocate a new structure explicitly here.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150908/7131d147/attachment-0001.html>
More information about the webkit-unassigned
mailing list