[Webkit-unassigned] [Bug 148769] Leak in WebContextInjectedBundleClient::getInjectedBundleInitializationUserData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148769

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
            Summary|UI process leaks            |Leak in
                   |InjectedBundleInitializatio |WebContextInjectedBundleCli
                   |nUserData                   |ent::getInjectedBundleIniti
                   |                            |alizationUserData

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #1)
> Adopting the pointer into the PassRefPtr in
> WebContextInjectedBundleClient::getInjectedBundleInitializationUserData()
> would probably fix the leak.

Yes, this fixes it:

-    return toImpl(m_client.getInjectedBundleInitializationUserData(toAPI(processPool), m_client.base.clientInfo));
+    return adoptRef(toImpl(m_client.getInjectedBundleInitializationUserData(toAPI(processPool), m_client.base.clientInfo));

A clue was that the result of toImpl was adopted one function up. 

(Feel free to submit the patch if you want, since you found it; otherwise I will.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150905/c7d46d94/attachment.html>