[Webkit-unassigned] [Bug 148846] Should have a test to make sure links don't navigate after a cancelled force click

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 16:51:28 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=148846

--- Comment #3 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #2)
> Comment on attachment 260649 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260649&action=review
> 
> > Tools/ChangeLog:3
> > +        Should have a text to make sure links don't navigate after a cancelled force 
> 
> s/text/test/
> 

Eep! Thanks!

> > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:470
> > +void EventSenderProxy::startAndCancelMouseForceClick()
> 
> Is this really a fundamental operation? It seems like this is one you should
> be able to build up from more fine-grained things, so that you can stop
> changing WKTR and just write tests that use a series of fundamental things.
> No?
> 
> But either way is fine :D

Tim and I talked about this in person. I do think that this is a fundamental operation, and I think that this is the right approach for these tests.

http://trac.webkit.org/changeset/189400

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150904/8b7e4f39/attachment-0001.html>


More information about the webkit-unassigned mailing list