[Webkit-unassigned] [Bug 148439] cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148439

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259970|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #18 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 259970
  --> https://bugs.webkit.org/attachment.cgi?id=259970
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259970&action=review

> Source/WTF/wtf/OSRandomSource.cpp:43
> +#if OS(DARWIN)

This is not the way we've been doing this recently. A better way to add forward declarations is to put them into a separate SPI header, as that lets us reuse the code, and to reduce the noise at the top of .cpp files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150904/a6789ffc/attachment.html>