[Webkit-unassigned] [Bug 148802] New: Add support for LOG(level, ...) in JavaScriptCore parts of Web Inspector code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148802

            Bug ID: 148802
           Summary: Add support for LOG(level, ...) in JavaScriptCore
                    parts of Web Inspector code
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bburg at apple.com
                CC: basile_clement at apple.com, fpizlo at apple.com,
                    joepeck at webkit.org, sbarati at apple.com,
                    timothy at apple.com
            Blocks: 147066

I want to add logging to both JSC and WebCore parts of Web Inspector for tracing things like frontends connecting/disconnecting, instrumentation being plugged/unplugged, etc. But, Logging.h (which allows toggling logging with NSUserDefaults) is only available in WebCore and WebKit/2. This patch would copy Logging.h down to JSC, and initialize logging channels in InitializeThreading.cpp alongside Options and other stuff. Then, it would be possible to use this log channel from JSC or WebCore, and flip one switch to enable all Inspector log tracing regardless of whether it's in JSC, WebCore, WK2.

Logging code gets compiled out if LOG_DISABLED is defined; by default, LOG_DISABLED == NDEBUG. This should not have any performance impact.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150904/87167a83/attachment.html>