[Webkit-unassigned] [Bug 148758] Need to be able to test default behaviors on force click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148758

--- Comment #5 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #4)
> Comment on attachment 260539 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260539&action=review
> 
> > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:102
> > +    _eventSender_subtype = NSWindowExposedEventType;
> 
> This is zero, so I think you should just omit it (I don't think this is
> really meant to be NSWindowExposedEventType, it just happens to be the same
> as 0).

You're right! I don't seem to need it.

> 
> > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:374
> > +    if ([m_testController->mainWebView()->platformView() hitTest:[event locationInWindow]])
> 
> Why bother with the hit test? We don't use its result, and don't need to do
> it.

Good catch! I removed it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150904/2ff9f45d/attachment.html>