[Webkit-unassigned] [Bug 147742] [ES6] Implement ES6 arrow function syntax. Prototype of arrow function should be undefined

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 2 22:39:01 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=147742

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259943|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 259943
  --> https://bugs.webkit.org/attachment.cgi?id=259943
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259943&action=review

r=me with comment.
If you upload again I'll cq+

> Source/JavaScriptCore/runtime/JSFunction.cpp:361
>      if (propertyName == exec->propertyNames().prototype) {

I think this code is more clear if we just check !executable->isArrowFunction()
here instead of doing it twice below.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150903/243a355c/attachment-0001.html>


More information about the webkit-unassigned mailing list