[Webkit-unassigned] [Bug 138566] AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 30 19:17:39 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=138566

--- Comment #9 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 264430
  --> https://bugs.webkit.org/attachment.cgi?id=264430
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264430&action=review

>>>> Source/WebCore/accessibility/AccessibilityObject.cpp:1857
>>>> +    for (Node* node = this->node(); node; node = node->parentNode()) {
>>> 
>>> there might be some ancestorsOfKind method that is better here
>> 
>> I see there's a ancestorsOfType method. But shouldn't we know the type of the ancestor first? Here the ariaModalNode can be any type right? Or is there another function to get the type of a node?
> 
> maybe use elementAncestors() and get the this->element() instead of the Node

In this case, don't we have to traverse farther than we need?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151031/58e40f62/attachment-0001.html>


More information about the webkit-unassigned mailing list